Skip to content

In Path tool when dragging a handle, make Alt recover the opposing handle if it's not cubic rather than zero-length #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 24, 2025
Merged

In Path tool when dragging a handle, make Alt recover the opposing handle if it's not cubic rather than zero-length #2196

merged 8 commits into from
Jan 24, 2025

Conversation

@bakayu
Copy link
Contributor

@bakayu bakayu commented Jan 13, 2025 •
edited by Keavon
Loading

Partly closes #1870.

Path tool

When dragging a handle:

  • Alt keeps the handles equidistant while pressed (instead of Shift in use now)
    • It also creates a matching handle if the other is zero-length or not a cubic Bézier

Also, fixes the following issues from the previous PR #2160:

@bakayu bakayu changed the title follow up of PR [#2160](https://github.com/GraphiteEditor/Graphite/pull/2160) follow up of PR #2160 Jan 13, 2025
@Keavon Keavon changed the title follow up of PR #2160 Make Path tool handle dragging recover the opposing handle when Alt is pressed Jan 15, 2025
@Keavon Keavon changed the title Make Path tool handle dragging recover the opposing handle when Alt is pressed Make Path tool handle dragging recover the opposing cubic handle when Alt is pressed if not cubic Jan 15, 2025
@Keavon Keavon force-pushed the master branch 2 times, most recently from 7465fad to ab724d8 Compare January 18, 2025 00:03
@bakayu bakayu marked this pull request as ready for review January 20, 2025 06:09
@Keavon
Copy link
Member

Keavon commented Jan 24, 2025

!build

@github-actions
Copy link

github-actions bot commented Jan 24, 2025

📦 Build Complete for c6b29a3
https://f8743a32.graphite.pages.dev

Keavon
Keavon reviewed Jan 24, 2025
View reviewed changes
Keavon
Keavon approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@Keavon Keavon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is technically one relatively insignificant problem but I'm going to let it slide in the interest of merging this now. Feel free to fix it in a later PR. If an opposing handle doesn't exist, because that segment is not cubic, pressing Alt works but then releasing the key puts it back in a way that permanently alters it such that it stays cubic and remains zero-length. So the net effect of tapping Alt is the permanent change from non-cubic to zero-length. It's subtle but not ideal. Thanks.

@Keavon Keavon changed the title Make Path tool handle dragging recover the opposing cubic handle when Alt is pressed if not cubic In Path tool when dragging a handle, make Alt recover the opposing handle if it's not cubic rather than zero-length Jan 24, 2025
@Keavon Keavon enabled auto-merge (squash) January 24, 2025 08:45
@Keavon Keavon mentioned this pull request Jan 24, 2025
Merged
@Keavon Keavon merged commit 6effb2d into GraphiteEditor:master Jan 24, 2025
4 checks passed
@Keavon Keavon mentioned this pull request Feb 5, 2025
Closed
31 tasks
@bakayu bakayu deleted the path-tool-update branch September 1, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Keavon Keavon Keavon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements

2 participants

@bakayu @Keavon